Skip to content

Conversation

jwasinger
Copy link
Contributor

The order of the checks was wrong which would have allowed a call to modexp with baseLen == 0 && modLen == 0 post fusaka.

Also handles an edge case where base/mod/exp length >= 2**64

…gment size cap check to catch case where base/exp/mod len > 2**64 (although this is unlikely to happen in practice)
@jwasinger jwasinger requested a review from rjl493456442 as a code owner August 7, 2025 11:14
@fjl fjl added the osaka label Aug 7, 2025
@fjl fjl merged commit a9a19c4 into ethereum:master Aug 15, 2025
4 of 5 checks passed
@fjl fjl added this to the 1.16.3 milestone Aug 15, 2025
yzang2019 added a commit to yzang2019/go-ethereum that referenced this pull request Aug 15, 2025
* master: (57 commits)
  core/vm: fix EIP-7823 modexp input length check (ethereum#32363)
  rlp: remove workaround for Value.Bytes (ethereum#32433)
  consensus/misc/eip4844: use blob parameters of current header (ethereum#32424)
  crypto/bn256: refactor to use bitutil.TestBytes (ethereum#32435)
  core/vm: refactor to use bitutil.TestBytes (ethereum#32434)
  cmd/evm: use PathScheme in blockrunner (ethereum#32444)
  trie, core/state: add the transition tree (verkle transition part 2) (ethereum#32366)
  build: remove unused functions (ethereum#32393)
  crypto/secp256k1: use ReadBits from common/math (ethereum#32430)
  build: upgrade -dlgo version to Go 1.25.0 (ethereum#32412)
  .github: upgrade workflows to Go 1.25 (ethereum#32425)
  p2p: refactor to use time.Now().UnixMilli() in golang std lib (ethereum#32402)
  eth/syncer: fix typo (ethereum#32427)
  eth/tracers: Adds codeHash to prestateTracer's response (ethereum#32391)
  rlp: optimize intsize (ethereum#32421)
  node: remove unused err var (ethereum#32398)
  eth: abort `requiredBlocks` check if peer handler terminated (ethereum#32413)
  cmd: fix inconsistent function name in comment (ethereum#32411)
  trie: refactor to use slices.Concat (ethereum#32401)
  consensus: fix ambiguous invalid gas limit error (ethereum#32405)
  ...
@karalabe
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants