Skip to content

accounts: use native subscribe filter logs #32371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

accounts: use native subscribe filter logs #32371

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a737ea1
modify the logs
wellnana Aug 8, 2025
ace2f95
Update accounts/abi/bind/v2/base.go
MariusVanDerWijden Aug 11, 2025
bf2de51
fix time out issue
wellnana Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions accounts/abi/bind/v2/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,24 +473,7 @@
if opts.End != nil {
config.ToBlock = new(big.Int).SetUint64(*opts.End)
}
/* TODO(karalabe): Replace the rest of the method below with this when supported
sub, err := c.filterer.SubscribeFilterLogs(ensureContext(opts.Context), config, logs)

Check failure on line 476 in accounts/abi/bind/v2/base.go

View workflow job for this annotation

GitHub Actions / Lint 

ineffectual assignment to err (ineffassign)
*/
buff, err := c.filterer.FilterLogs(ensureContext(opts.Context), config)
if err != nil {
return nil, nil, err
}
sub := event.NewSubscription(func(quit <-chan struct{}) error {
for _, log := range buff {
select {
case logs <- log:
case <-quit:
return nil
}
}
return nil
})

return logs, sub, nil
}

Expand Down
Loading