Skip to content

fix(gethclient): pass common.Hash to debug_traceTransaction for consistency #32404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(gethclient): pass common.Hash to debug_traceTransaction for consistency #32404

wants to merge 1 commit into from

Conversation

Fibonacci747
Copy link

  • Unifies hash argument encoding: TraceTransaction now passes common.Hash directly, matching TraceBlock and other RPC calls.
  • Leverages common.Hash JSON marshaling (0x‑prefixed hex via MarshalText); no functional change expected.
  • Aligns with RPC handler signature (tracers.API.TraceBlockByHash(ctx, hash common.Hash, ...)) and existing ethclient usage (e.g., eth_getBlockByHash, eth_getTransactionByHash).
  • Simplifies code by avoiding unnecessary Hex() conversion and improves consistency/readability.

@Fibonacci747
fix(gethclient): pass common.Hash to debug_traceTransaction for consi…
e7e69c5 
…stency

Unifies hash argument encoding: TraceTransaction now passes common.Hash directly, matching TraceBlock and other RPC calls.
Leverages common.Hash JSON marshaling (0x‑prefixed hex via MarshalText); no functional change expected.
Aligns with RPC handler signature (tracers.API.TraceBlockByHash(ctx, hash common.Hash, ...)) and existing ethclient usage (e.g., eth_getBlockByHash, eth_getTransactionByHash).
Simplifies code by avoiding unnecessary Hex() conversion and improves consistency/readability.
@Fibonacci747 Fibonacci747 requested a review from fjl as a code owner August 12, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Fibonacci747