-
Notifications
You must be signed in to change notification settings - Fork 21.4k
internal/ethapi: add transient storage override support for eth_call #32680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
83a8465
to
720946f
Compare
@s1na do these types of overrides need to be represented in rpc specs? |
@hero5512 this is still a draft - is that intentional? |
Yes, there are still some issues with this PR. |
@s1na This pr is ready to review. Please take a look. |
@lightclient The good: they are all standardized as part of eth_simulateV1 The bad: not specified in the specs for eth_call and eth_estimateGas The ugly: I think only geth and reth support them in eth_call and eth_estimateGas |
I don't like adding transient storage to the state overrides. They are different. State overrides can be for a longer context than a transaction, e.g. in eth_simulateV1 you do a state override per block. I'd add it as a new parameter. |
okay. I've refactored the implementation to separate transient storage overrides into a seperate parameter. |
this pr implements #32671, adding an override for the transient storage function in eth_call.