eth/fetcher: remove alternates, announced maps #32773
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
alternates
andannounced
maps intx_fetcher
.alternates
map is used only to check whether a transaction is in stage 2 (queued), and theannounced
map is used only to check whether a transaction is in stage 3 (fetching).announces
map). So maintaining two separate maps seems unnecessary.announces
map, which is shared across stage 2 and stage 3, to perform the same check.Given that the peer set is usually small (e.g., 50 by default), this iteration is expected to be fast.