core: prevent no-op code change for 7702 edge-cases #32915
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… account that wasn't previously delegated, re-delegating to the same contract that was previously-delegated.
Usernamefrzadyny3
approved these changes
Oct 15, 2025
Makes sense, what about avoiding the hook invocation directly at SetCode? |
|
That's one option. it just feels a bit cleaner to do it this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two 7702 edge-cases where we will set code of an account when it did not actually change:
The motivation behind this PR is mainly that I think tracing code change hooks should only be invoked if there is an actual code change.