Skip to content

cmd/utils: use maximum uint64 value for receipt chain insertion #32934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2025
+2 −1
Merged

cmd/utils: use maximum uint64 value for receipt chain insertion #32934

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db0dea
fix: use maximum uint64 value for receipt chain insertion
johnzhu0907 Oct 17, 2025
af06e6d
fix: use math.MaxUint64 instead of ^uint64(0)
johnzhu0907 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/utils/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ func ImportHistory(chain *core.BlockChain, dir string, network string) error {
return fmt.Errorf("error reading receipts %d: %w", it.Number(), err)
}
encReceipts := types.EncodeBlockReceiptLists([]types.Receipts{receipts})
if _, err := chain.InsertReceiptChain([]*types.Block{block}, encReceipts, 2^64-1); err != nil {
if _, err := chain.InsertReceiptChain([]*types.Block{block}, encReceipts, ^uint64(0)); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use math.MaxUint64 here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, use math.MaxUint64 to improve readability.

return fmt.Errorf("error inserting body %d: %w", it.Number(), err)
}
imported += 1
Expand Down