cmd/devp2p/internal/ethtest: cover acceptable differences in communication #33031
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flcl42
commented
Oct 27, 2025
|
|
||
| // Check if peer disconnects at the end. | ||
| code, _, err := conn.Read() | ||
| if err == errDisc || code == discMsg { |
There was a problem hiding this comment.
@fjl It seems like the test fails when we do disconnect, or I'm missing something obvious
There was a problem hiding this comment.
Yeah looks like geth sends back empty BlockHeadersMsgs, which kinda ok, but not handled by the test, imho. Does it disconnect then? Not sure if it sends disconnect message or just disconnects.
Nethermind just sends disconnect message on the very first package, which seems correct
There was a problem hiding this comment.
Hm probably the difference is also in how we handle ^uint64(0) as Origin of GetBlockHeadersRequest. And test does not test what's intended in case of Nethermind (we can't handle max uint64 and immediately disconnect)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.