Skip to content

Conversation

@cuiweixie
Copy link
Contributor

func BenchmarkOsakaMultComplexity(b *testing.B) {
	var input uint64 = 123456789
	b.ResetTimer()
	for i := 0; i < b.N; i++ {
		_ = osakaMultComplexity(input)
	}
}
goos: darwin
goarch: arm64
pkg: github.com/ethereum/go-ethereum/core/vm
cpu: Apple M1 Pro
                       │   old.txt    │               new.txt               │
                       │    sec/op    │    sec/op     vs base               │
OsakaMultComplexity-10   0.3145n ± 1%   0.3124n ± 0%  -0.68% (p=0.003 n=10)

                       │  old.txt   │            new.txt             │
                       │    B/op    │    B/op     vs base            │
OsakaMultComplexity-10   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

                       │  old.txt   │            new.txt             │
                       │ allocs/op  │ allocs/op   vs base            │
OsakaMultComplexity-10   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@cuiweixie cuiweixie force-pushed the osakaMultComplexity branch from 07ffc25 to cae375f Compare November 4, 2025 22:44
@rjl493456442
Copy link
Member

OsakaMultComplexity-10 0.3145n ± 1% 0.3124n ± 0% -0.68% (p=0.003 n=10)

no difference?

@cuiweixie
Copy link
Contributor Author

OsakaMultComplexity-10 0.3145n ± 1% 0.3124n ± 0% -0.68% (p=0.003 n=10)

no difference?
base on implementation, minor improvements.

@rjl493456442
Copy link
Member

Since the performance difference is negligible, i would prefer to not include this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants