Skip to content

triedb/pathdb: fix ID assignment in history inspection #33103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2025
Merged

triedb/pathdb: fix ID assignment in history inspection #33103

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67e689e
triedb/pathdb: fix off-by-one for last state history ID and handle em…
Forostovec Nov 5, 2025
591e858
add test
Forostovec Nov 6, 2025
00e0f2b
Delete triedb/pathdb/history_inspect_test.go
Forostovec Nov 10, 2025
9cb3931
Update history_inspect.go
Forostovec Nov 10, 2025
49e72a8
Simplify error handling in history inspection
rjl493456442 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions triedb/pathdb/history_inspect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func sanitizeRange(start, end uint64, freezer ethdb.AncientReader) (uint64, uint
if err != nil {
return 0, 0, err
}
last := head - 1
last := head
if end != 0 && end < last {
last = end
}
Expand Down Expand Up @@ -143,7 +143,7 @@ func historyRange(freezer ethdb.AncientReader) (uint64, uint64, error) {
if err != nil {
return 0, 0, err
}
last := head - 1
last := head

fh, err := readStateHistory(freezer, first)
if err != nil {
Expand Down