node: remove databases from map only after successful Close #33117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We have received numerous PRs and it has increased the burden on our reviewers. While the sentiment makes sense, I would point out that the errors are already saved for debugging purposes, and that you do not implement any retry. So this PR is effectively a no-op. We will be closing it. Feel free to open a new one, if you implement a handling of the failure in a valuable way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
Node.closeDatabasesremoves entries fromn.databasesonly after a successfulClose(), preserving failed entries for diagnostics.Previously, databases were deleted from the map before close. On close errors, we lost traceability for which DB failed and prevented potential retries/inspection.