p2p/enode: migrate nodedb from leveldb to pebble #33208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherrypick14
force-pushed
the
migrate-nodedb-to-pebble
branch
from
a0c7e5e to
163782f
Compare
Member
|
I don't think it's required at this point. Leveldb for peernode works very well, we should keep using it until leveldb is totally deprecated from our dependency. |
Author
|
Hi @rjl493456442 thanks for the updates. I initially wanted to ask why you guys are migrating from leveldb to pebble and it seems you have clarified this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33000
This PR migrates the node database in
p2p/enodefrom LevelDB to Pebble, aligning it with the rest of the geth codebase which has already transitioned to Pebble.Changes
leveldb.DBto theethdb.KeyValueStoreinterface.memorydb.New()andpebble.New().QuerySeeds()- can't useSeek()with the ethdb interface, so now we create iterators with the start position.Testing
TestDBSeedQuery- Random seed querying works correctly.TestDBPersistency- Database persistence across restarts.TestDBExpiration- Node expiration logic.