Skip to content

eth/tracers: add WithRemovedLog option to mark failed logs as removed #33210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

eth/tracers: add WithRemovedLog option to mark failed logs as removed #33210

wants to merge 2 commits into from

Conversation

@levin-p
Copy link

@levin-p levin-p commented Nov 17, 2025 •
edited
Loading

Summary

  • Add WithRemovedLog config option to callTracerConfig
  • Add Removed field to callLog struct
  • Modify clearFailedLogs to mark logs as removed instead of deleting them when WithRemovedLog is true

Motivation

When analyzing failed transactions, reverted logs can provide valuable information for debugging and understanding transaction behavior.

Test plan

  • Test callTracer with WithRemovedLog: true on failed transactions
  • Verify logs are marked as removed rather than deleted
  • Ensure backward compatibility when WithRemovedLog: false (default)

@levin-p levin-p requested a review from s1na as a code owner November 17, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1na s1na Awaiting requested review from s1na s1na is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@levin-p