Skip to content

core/state/snapshot: race resulting in generate() goroutine leak #33230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Draft

core/state/snapshot: race resulting in generate() goroutine leak #33230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/state/snapshot/generate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import (
"github.com/ethereum/go-ethereum/triedb/hashdb"
"github.com/ethereum/go-ethereum/triedb/pathdb"
"github.com/holiman/uint256"
"go.uber.org/goleak"
"golang.org/x/crypto/sha3"
)

Expand All @@ -53,6 +54,8 @@ func TestGeneration(t *testing.T) {
}

func testGeneration(t *testing.T, scheme string) {
defer goleak.VerifyNone(t)

// We can't use statedb to make a test trie (circular dependency), so make
// a fake one manually. We're going with a small account trie of 3 accounts,
// two of which also has the same 3-slot storage trie attached.
Expand Down Expand Up @@ -80,9 +83,7 @@ func testGeneration(t *testing.T, scheme string) {
checkSnapRoot(t, snap, root)

// Signal abortion to the generator and wait for it to tear down
stop := make(chan *generatorStats)
snap.genAbort <- stop
<-stop
snap.stopGeneration()
}

// Tests that snapshot generation with existent flat state.
Expand Down
Loading