Skip to content

common: avoid fmt.Sprintf in PrettyAge #33294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Doryu001 wants to merge 1 commit into from
Closed

common: avoid fmt.Sprintf in PrettyAge #33294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions common/format.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
package common

import (
"fmt"
"regexp"
"strconv"
"strings"
"time"
)
Expand Down Expand Up @@ -66,17 +66,21 @@ func (t PrettyAge) String() string {
return "0"
}
// Accumulate a precision of 3 components before returning
result, prec := "", 0
var (
builder strings.Builder
prec int
)

for _, unit := range ageUnits {
if diff >= unit.Size {
result = fmt.Sprintf("%s%d%s", result, diff/unit.Size, unit.Symbol)
builder.WriteString(strconv.FormatInt(int64(diff/unit.Size), 10))
builder.WriteString(unit.Symbol)
diff %= unit.Size

if prec += 1; prec >= 3 {
break
}
}
}
return result
return builder.String()
}