Skip to content

core/vm: remove unused minStack helpers and inline values #33298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

core/vm: remove unused minStack helpers and inline values #33298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b3fdbb
vm: inline minStack/minDupStack/minSwapStack and delete unused functions
Sahil-4555 Nov 27, 2025
16df2f4
fix lint
Sahil-4555 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions core/vm/eips.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func enable1884(jt *JumpTable) {
jt[SELFBALANCE] = &operation{
execute: opSelfBalance,
constantGas: GasFastStep,
minStack: minStack(0, 1),
minStack: 0,
maxStack: maxStack(0, 1),
}
}
Expand All @@ -103,7 +103,7 @@ func enable1344(jt *JumpTable) {
jt[CHAINID] = &operation{
execute: opChainID,
constantGas: GasQuickStep,
minStack: minStack(0, 1),
minStack: 0,
maxStack: maxStack(0, 1),
}
}
Expand Down Expand Up @@ -175,7 +175,7 @@ func enable3198(jt *JumpTable) {
jt[BASEFEE] = &operation{
execute: opBaseFee,
constantGas: GasQuickStep,
minStack: minStack(0, 1),
minStack: 0,
maxStack: maxStack(0, 1),
}
}
Expand All @@ -187,14 +187,14 @@ func enable1153(jt *JumpTable) {
jt[TLOAD] = &operation{
execute: opTload,
constantGas: params.WarmStorageReadCostEIP2929,
minStack: minStack(1, 1),
minStack: 1,
maxStack: maxStack(1, 1),
}

jt[TSTORE] = &operation{
execute: opTstore,
constantGas: params.WarmStorageReadCostEIP2929,
minStack: minStack(2, 0),
minStack: 2,
maxStack: maxStack(2, 0),
}
}
Expand Down Expand Up @@ -232,7 +232,7 @@ func enable3855(jt *JumpTable) {
jt[PUSH0] = &operation{
execute: opPush0,
constantGas: GasQuickStep,
minStack: minStack(0, 1),
minStack: 0,
maxStack: maxStack(0, 1),
}
}
Expand All @@ -257,7 +257,7 @@ func enable5656(jt *JumpTable) {
execute: opMcopy,
constantGas: GasFastestStep,
dynamicGas: gasMcopy,
minStack: minStack(3, 0),
minStack: 3,
maxStack: maxStack(3, 0),
memorySize: memoryMcopy,
}
Expand Down Expand Up @@ -307,7 +307,7 @@ func enable4844(jt *JumpTable) {
jt[BLOBHASH] = &operation{
execute: opBlobHash,
constantGas: GasFastestStep,
minStack: minStack(1, 1),
minStack: 1,
maxStack: maxStack(1, 1),
}
}
Expand All @@ -317,7 +317,7 @@ func enable7939(jt *JumpTable) {
jt[CLZ] = &operation{
execute: opCLZ,
constantGas: GasFastStep,
minStack: minStack(1, 1),
minStack: 1,
maxStack: maxStack(1, 1),
}
}
Expand All @@ -327,7 +327,7 @@ func enable7516(jt *JumpTable) {
jt[BLOBBASEFEE] = &operation{
execute: opBlobBaseFee,
constantGas: GasQuickStep,
minStack: minStack(0, 1),
minStack: 0,
maxStack: maxStack(0, 1),
}
}
Expand All @@ -338,7 +338,7 @@ func enable6780(jt *JumpTable) {
execute: opSelfdestruct6780,
dynamicGas: gasSelfdestructEIP3529,
constantGas: params.SelfdestructGasEIP150,
minStack: minStack(1, 0),
minStack: 1,
maxStack: maxStack(1, 0),
}
}
Expand All @@ -348,19 +348,19 @@ func enable8024(jt *JumpTable) {
jt[DUPN] = &operation{
execute: opDupN,
constantGas: GasFastestStep,
minStack: minStack(1, 0),
minStack: 1,
maxStack: maxStack(0, 1),
}
jt[SWAPN] = &operation{
execute: opSwapN,
constantGas: GasFastestStep,
minStack: minStack(2, 0),
minStack: 2,
maxStack: maxStack(0, 0),
}
jt[EXCHANGE] = &operation{
execute: opExchange,
constantGas: GasFastestStep,
minStack: minStack(2, 0),
minStack: 2,
maxStack: maxStack(0, 0),
}
}
Expand Down Expand Up @@ -450,41 +450,41 @@ func enable4762(jt *JumpTable) {
jt[SSTORE] = &operation{
dynamicGas: gasSStore4762,
execute: opSstore,
minStack: minStack(2, 0),
minStack: 2,
maxStack: maxStack(2, 0),
}
jt[SLOAD] = &operation{
dynamicGas: gasSLoad4762,
execute: opSload,
minStack: minStack(1, 1),
minStack: 1,
maxStack: maxStack(1, 1),
}

jt[BALANCE] = &operation{
execute: opBalance,
dynamicGas: gasBalance4762,
minStack: minStack(1, 1),
minStack: 1,
maxStack: maxStack(1, 1),
}

jt[EXTCODESIZE] = &operation{
execute: opExtCodeSize,
dynamicGas: gasExtCodeSize4762,
minStack: minStack(1, 1),
minStack: 1,
maxStack: maxStack(1, 1),
}

jt[EXTCODEHASH] = &operation{
execute: opExtCodeHash,
dynamicGas: gasExtCodeHash4762,
minStack: minStack(1, 1),
minStack: 1,
maxStack: maxStack(1, 1),
}

jt[EXTCODECOPY] = &operation{
execute: opExtCodeCopyEIP4762,
dynamicGas: gasExtCodeCopyEIP4762,
minStack: minStack(4, 0),
minStack: 4,
maxStack: maxStack(4, 0),
memorySize: memoryExtCodeCopy,
}
Expand All @@ -493,7 +493,7 @@ func enable4762(jt *JumpTable) {
execute: opCodeCopy,
constantGas: GasFastestStep,
dynamicGas: gasCodeCopyEip4762,
minStack: minStack(3, 0),
minStack: 3,
maxStack: maxStack(3, 0),
memorySize: memoryCodeCopy,
}
Expand All @@ -502,15 +502,15 @@ func enable4762(jt *JumpTable) {
execute: opSelfdestruct6780,
dynamicGas: gasSelfdestructEIP4762,
constantGas: params.SelfdestructGasEIP150,
minStack: minStack(1, 0),
minStack: 1,
maxStack: maxStack(1, 0),
}

jt[CREATE] = &operation{
execute: opCreate,
constantGas: params.CreateNGasEip4762,
dynamicGas: gasCreateEip3860,
minStack: minStack(3, 1),
minStack: 3,
maxStack: maxStack(3, 1),
memorySize: memoryCreate,
}
Expand All @@ -519,54 +519,54 @@ func enable4762(jt *JumpTable) {
execute: opCreate2,
constantGas: params.CreateNGasEip4762,
dynamicGas: gasCreate2Eip3860,
minStack: minStack(4, 1),
minStack: 4,
maxStack: maxStack(4, 1),
memorySize: memoryCreate2,
}

jt[CALL] = &operation{
execute: opCall,
dynamicGas: gasCallEIP4762,
minStack: minStack(7, 1),
minStack: 7,
maxStack: maxStack(7, 1),
memorySize: memoryCall,
}

jt[CALLCODE] = &operation{
execute: opCallCode,
dynamicGas: gasCallCodeEIP4762,
minStack: minStack(7, 1),
minStack: 7,
maxStack: maxStack(7, 1),
memorySize: memoryCall,
}

jt[STATICCALL] = &operation{
execute: opStaticCall,
dynamicGas: gasStaticCallEIP4762,
minStack: minStack(6, 1),
minStack: 6,
maxStack: maxStack(6, 1),
memorySize: memoryStaticCall,
}

jt[DELEGATECALL] = &operation{
execute: opDelegateCall,
dynamicGas: gasDelegateCallEIP4762,
minStack: minStack(6, 1),
minStack: 6,
maxStack: maxStack(6, 1),
memorySize: memoryDelegateCall,
}

jt[PUSH1] = &operation{
execute: opPush1EIP4762,
constantGas: GasFastestStep,
minStack: minStack(0, 1),
minStack: 0,
maxStack: maxStack(0, 1),
}
for i := 1; i < 32; i++ {
jt[PUSH1+OpCode(i)] = &operation{
execute: makePushEIP4762(uint64(i+1), i+1),
constantGas: GasFastestStep,
minStack: minStack(0, 1),
minStack: 0,
maxStack: maxStack(0, 1),
}
}
Expand Down
Loading