Skip to content

cmd/utils: fix dump config failed #33302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

cmd/utils: fix dump config failed #33302

merged 1 commit into from
Nov 28, 2025
+4 −5

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Nov 27, 2025 •
edited
Loading

dumpconfig subcommand will failed with current master code.

INFO [11-27|19:08:50.204] Maximum peer count                       ETH=50 total=50
INFO [11-27|19:08:50.215] Set global gas cap                       cap=50,000,000
INFO [11-27|19:08:50.218] Initializing the KZG library             backend=gokzg
toml: cannot marshal nil *int

@cuiweixie cuiweixie force-pushed the fix_dumpconfig_failed branch from 65a2ed8 to 7a08ec3 Compare November 27, 2025 11:31
fjl
fjl approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@fjl fjl added this to the 1.16.8 milestone Nov 28, 2025
@fjl fjl merged commit f432281 into ethereum:master Nov 28, 2025
7 of 8 checks passed
fjl pushed a commit to lightclient/go-ethereum that referenced this pull request Nov 28, 2025
@cuiweixie @fjl
cmd/utils: fix dumpconfig (ethereum#33302)
9f9889b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjl fjl fjl approved these changes

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.8

Development

Successfully merging this pull request may close these issues.

2 participants

@cuiweixie @fjl