beacon/engine, rpc: add PremarshaledJSON for execution payload envelopes#33969
Draft
jrhea wants to merge 2 commits intoethereum:masterfrom
Draft
beacon/engine, rpc: add PremarshaledJSON for execution payload envelopes#33969jrhea wants to merge 2 commits intoethereum:masterfrom
jrhea wants to merge 2 commits intoethereum:masterfrom
Conversation
61a5354 to
7f4a3c0
Compare
7f4a3c0 to
bc84b4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a PremarshaledJSON fast path for ExecutionPayloadEnvelope that bypasses encoding/json's reflection and re-validation, which are expensive for large payloads with many blobs.
TODO Maybe?:
The
PremarshaledJSONmethod in premarshal.go is currently hand-written. IfExecutionPayloadEnvelopechanges, the code must be updated manually. To make this sustainable, gencodec could be extended to emit PremarshaledJSON() alongside MarshalJSON().