-
Notifications
You must be signed in to change notification settings - Fork 103
ci: provenance build and publish #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why is consistent git check useful? |
I personally find it helpful to ensure there are no unintended side-effects or new artifacts as part of in particular build but also tests. While |
8f1dc69
to
d37b983
Compare
Let’s remove git check for 2 reasons:
|
And of course reason number 3: Too many checks degrade devEx terribly. I’ve once tried contributing to some old eth ecosystem pkg. it had all sorts of checks: pre commit hook, linters and others. at some point I was not able to commit to the repo — it was too complex. So, for non important things, the less, the better. |
d37b983
to
7cc102b
Compare
7cc102b
to
599123b
Compare
Removed the checks!
I can very much sympathize with point especially point 3..
Though I'd still recommend checking to catch such discrepancies in CI (like a new [`*.js`](https://github.com/ethereum/js-ethereum-cryptography/blob/2f7e6f303c4848970e9fabfcab4a0ecb0bd2a88f/package.json#L13) or `*.d.ts` file inadvertently being created or changed in such a way as you describe down the line...) at least for publish - and therefore for build - but perhaps for another day, then!
|
no we need to find someone with root repo access who can add npm keys to ENV vars |
Related