Skip to content

Commit 569849c

Browse files
committed
Use fork data from the state rather than derived from the params
This change is more in line with how this functionality will ultimately be used so we want to route our query through the `BeaconState`.
1 parent e15e3e6 commit 569849c

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tests/beacon/test_helpers.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -893,18 +893,17 @@ def test_verify_slashable_vote_data_signature(num_validators,
893893
# touch disjoint subsets of the provided params
894894
messages = _create_slashable_vote_data_messages(sample_slashable_vote_data_params)
895895

896-
fork_data = ForkData(**sample_fork_data_params)
897896
valid_params = _correct_slashable_vote_data_params(
898897
num_validators,
899898
sample_slashable_vote_data_params,
900899
messages,
901900
privkeys,
902-
fork_data,
901+
state.fork_data,
903902
)
904903
valid_votes = SlashableVoteData(**valid_params)
905904
assert verify_slashable_vote_data_signature(state, valid_votes)
906905

907-
invalid_params = _corrupt_signature(valid_params, fork_data)
906+
invalid_params = _corrupt_signature(valid_params, state.fork_data)
908907
invalid_votes = SlashableVoteData(**invalid_params)
909908
assert not verify_slashable_vote_data_signature(state, invalid_votes)
910909

@@ -967,16 +966,15 @@ def test_verify_slashable_vote_data(num_validators,
967966
# touch disjoint subsets of the provided params
968967
messages = _create_slashable_vote_data_messages(sample_slashable_vote_data_params)
969968

970-
fork_data = ForkData(**sample_fork_data_params)
971969
params = _correct_slashable_vote_data_params(
972970
num_validators,
973971
sample_slashable_vote_data_params,
974972
messages,
975973
privkeys,
976-
fork_data,
974+
state.fork_data,
977975
)
978976
if needs_fork_data:
979-
params = param_mapper(params, fork_data)
977+
params = param_mapper(params, state.fork_data)
980978
else:
981979
params = param_mapper(params)
982980
_run_verify_slashable_vote(params, state, max_casper_votes, should_succeed)

0 commit comments

Comments
 (0)