Skip to content

Commit c8a2bbe

Browse files
committed
Use fork data from the state rather than derived from the params
This change is more in line with how this functionality will ultimately be used so we want to route our query through the `BeaconState`.
1 parent 3b3338c commit c8a2bbe

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tests/beacon/test_helpers.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -918,18 +918,17 @@ def test_verify_slashable_vote_data_signature(num_validators,
918918
# touch disjoint subsets of the provided params
919919
messages = _create_slashable_vote_data_messages(sample_slashable_vote_data_params)
920920

921-
fork_data = ForkData(**sample_fork_data_params)
922921
valid_params = _correct_slashable_vote_data_params(
923922
num_validators,
924923
sample_slashable_vote_data_params,
925924
messages,
926925
privkeys,
927-
fork_data,
926+
state.fork_data,
928927
)
929928
valid_votes = SlashableVoteData(**valid_params)
930929
assert verify_slashable_vote_data_signature(state, valid_votes)
931930

932-
invalid_params = _corrupt_signature(valid_params, fork_data)
931+
invalid_params = _corrupt_signature(valid_params, state.fork_data)
933932
invalid_votes = SlashableVoteData(**invalid_params)
934933
assert not verify_slashable_vote_data_signature(state, invalid_votes)
935934

@@ -992,16 +991,15 @@ def test_verify_slashable_vote_data(num_validators,
992991
# touch disjoint subsets of the provided params
993992
messages = _create_slashable_vote_data_messages(sample_slashable_vote_data_params)
994993

995-
fork_data = ForkData(**sample_fork_data_params)
996994
params = _correct_slashable_vote_data_params(
997995
num_validators,
998996
sample_slashable_vote_data_params,
999997
messages,
1000998
privkeys,
1001-
fork_data,
999+
state.fork_data,
10021000
)
10031001
if needs_fork_data:
1004-
params = param_mapper(params, fork_data)
1002+
params = param_mapper(params, state.fork_data)
10051003
else:
10061004
params = param_mapper(params)
10071005
_run_verify_slashable_vote(params, state, max_casper_votes, should_succeed)

0 commit comments

Comments
 (0)