Preliminary london fixups #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making sure that London headers are created properly
carver
force-pushed
the
prelim-london-fixups
branch
from
fe2d822 to
94573ef
Compare
fselmo
reviewed
Sep 2, 2021
| genesis_fields = genesis_fields_from_fixture(fixture) | ||
|
|
||
| genesis_block = chain.get_canonical_block_by_number(0) | ||
| genesis_header = genesis_block.header | ||
|
|
||
| # Validate the genesis header RLP against the generated header | ||
| if 'genesisRLP' in fixture: | ||
| # Super hacky, but better than nothing: extract the header, then re-decode it |
fselmo
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When enabling London tests, some basic missing/broken functionality showed up.
How was it fixed?
To-Do
Cute Animal Picture