Skip to content

Conversation

marcocastignoli
Copy link
Member

@marcocastignoli marcocastignoli commented Aug 12, 2025

This PR moves the "Import from Etherscan" base methods from server to lib-sourcify. After we merge this PR and a new version of lib-sourcify is published, we are going to use the same "Import from Etherscan" functionalities in the verification UI fixing #2233, #2232 and #2238

TODO

  • documentation for lib-sourcify

@marcocastignoli marcocastignoli marked this pull request as ready for review August 13, 2025 08:55
@kuzdogan kuzdogan self-assigned this Aug 13, 2025
@kuzdogan kuzdogan moved this from Triage to Sprint - In Progress in Sourcify Public [Archived] Aug 13, 2025
@kuzdogan kuzdogan force-pushed the lib-sourcify-etherscan-utils branch from 12e6426 to bf5ad13 Compare August 13, 2025 11:50
Copy link
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. Small things

I just renamed the url in the etherscan-utils to maskedUrl following the commit 0a417e6 that happened while you were working on this

@marcocastignoli marcocastignoli force-pushed the lib-sourcify-etherscan-utils branch from b0dd51c to d894692 Compare August 13, 2025 15:17
@marcocastignoli
Copy link
Member Author

@kuzdogan I had to rebase it again because of conflicts with staging. Now it should be ready.

@marcocastignoli marcocastignoli merged commit 9f29a73 into staging Aug 14, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Sprint - In Progress to Sprint - Done in Sourcify Public [Archived] Aug 14, 2025
@marcocastignoli marcocastignoli deleted the lib-sourcify-etherscan-utils branch August 14, 2025 07:02
@kuzdogan kuzdogan moved this from Sprint - Done to COMPLETED in Sourcify Public [Archived] Aug 14, 2025
@stackenbotten3000 stackenbotten3000 moved this to COMPLETED in Sourcify Public Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

2 participants