This repository was archived by the owner on Jul 1, 2021. It is now read-only.
CI: rename EIP15{0,8} tox jobs to their long-form fork names. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veox
changed the title
Everywhere else in the codebase, EIP15{0,8} remain.
veox
force-pushed
the
rename-eipxxx-ci-jobs
branch
from
eb3217b to
48aaab2
Compare
veox
changed the title
cburgdorf
approved these changes
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fallout from PR ethereum/py-evm#1577 (comment).
Closes #102.
CI jobs have
eip150,eip158in their names.One has to know the numbers refer to hard-forks to understand jobs don't check for kitty support, or the like.
How was it fixed?
Renamed CI job name (label only).
(Or was the original request to rename it throughout the codebase?..)
Cute Animal Picture
Source: thumbnail of a video on framepool