Skip to content

Commit f49203b

Browse files
committed
Add note to underpriced transaction tests for clarity to readers
1 parent 2bd70d8 commit f49203b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

web3/_utils/module_testing/eth_module.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2329,6 +2329,9 @@ async def test_async_eth_replace_transaction_underpriced(
23292329
async_w3: "AsyncWeb3",
23302330
async_keyfile_account_address_dual_type: ChecksumAddress,
23312331
) -> None:
2332+
# Note: `underpriced transaction` error is only consistent with
2333+
# ``txpool.nolocals`` flag as of Geth ``v1.15.4``.
2334+
# https://github.com/ethereum/web3.py/pull/3636
23322335
txn_params: TxParams = {
23332336
"from": async_keyfile_account_address_dual_type,
23342337
"to": async_keyfile_account_address_dual_type,
@@ -3528,6 +3531,9 @@ def test_eth_replace_transaction(
35283531
def test_eth_replace_transaction_underpriced(
35293532
self, w3: "Web3", keyfile_account_address_dual_type: ChecksumAddress
35303533
) -> None:
3534+
# Note: `underpriced transaction` error is only consistent with
3535+
# ``txpool.nolocals`` flag as of Geth ``v1.15.4``.
3536+
# https://github.com/ethereum/web3.py/pull/3636
35313537
txn_params: TxParams = {
35323538
"from": keyfile_account_address_dual_type,
35333539
"to": keyfile_account_address_dual_type,

0 commit comments

Comments
 (0)