Skip to content

Add transaction tests for type 1 and type 2 with accessList (Fixes #3707) #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

darkiss7
Copy link

@darkiss7 darkiss7 commented Aug 4, 2025

What was wrong?

Lack of test coverage for certain eth_sendTransaction use cases involving accessList.

Related to Issue: #3707
Closes #3707

How was it fixed?

Added two new tests in test_transactions.py:

✅ test_send_type1_transaction_with_access_list

✅ test_send_type2_transaction_with_access_list

These tests validate Web3.py's transaction formatters for:

Type 1 transactions (Legacy, with access list)

Type 2 transactions (EIP-1559, with access list)

All tests pass using the EthereumTester backend. Code is formatted with black, passes flake8, and other pre-commit hooks.

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes (N/A for tests)

  • Add entry to the release notes (optional)

Cute Animal Picture

@darkiss7
Copy link
Author

darkiss7 commented Aug 4, 2025

Hi, I pushed my changes but the CI fails on test_key_generation_is_deterministic with a Hypothesis FailedHealthCheck: Input generation is slow.

This test passes fine locally but fails on CI due to input generation speed.

I’m considering adding @settings(suppress_health_check=[HealthCheck.too_slow]) to fix this, but wanted to check if that’s the preferred approach or if you have other suggestions.

Thanks for your help!

@darkiss7 darkiss7 closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more transaction tests
1 participant