Lint test/net, test/rpc, test/util

Author: cgewecke

test/net/peer/peer.ts

@@ -1,3 +1,6 @@
+/* eslint-disable */
+// TODO: re-enable linting. Disabled because much of test is commented out
+// resulting in unused variable false positives
 import tape from 'tape-catch'
 const td = require('testdouble')
 import { Peer } from '../../../lib/net/peer'

test/net/peer/rlpxpeer.ts

@@ -1,3 +1,6 @@
+/* eslint-disable */
+// TODO: re-enable linting. Disabled because much of test is commented out
+// resulting in unused variable false positives
 import tape from 'tape-catch'
 const td = require('testdouble')
 import { EventEmitter } from 'events'

test/net/peerpool.ts

@@ -6,7 +6,7 @@ defaultLogger.silent = true
 
 tape('[PeerPool]', (t) => {
   const Peer = td.replace('../../lib/net/peer/peer', function (this: any, id: any) {
-    this.id = id
+    this.id = id // eslint-disable-line no-invalid-this
   })
   const PeerPool = require('../../lib/net/peerpool').PeerPool
 

test/net/protocol/ethprotocol.ts

@@ -1,9 +1,11 @@
+/* eslint-disable */
+// TODO: re-enable linting. Disabled because much of test is commented out
+// resulting in unused variable false positives
 import tape from 'tape-catch'
+import { BN } from 'ethereumjs-util'
 import { Chain } from '../../../lib/blockchain/chain'
 const { EthProtocol } = require('../../../lib/net/protocol')
 
-const BN = require('bn.js')
-
 tape('[EthProtocol]', (t) => {
   t.test('should get properties', (t) => {
     const p = new EthProtocol({})

test/net/protocol/lesprotocol.ts

@@ -1,7 +1,10 @@
+/* eslint-disable */
+// TODO: re-enable linting. Disabled because much of test is commented out
+// resulting in unused variable false positives
 import tape from 'tape-catch'
+import { BN } from 'ethereumjs-util'
 import { Chain } from '../../../lib/blockchain'
 const { LesProtocol } = require('../../../lib/net/protocol')
-const BN = require('bn.js')
 
 tape('[LesProtocol]', (t) => {
   t.test('should get properties', (t) => {

test/net/protocol/libp2psender.ts

@@ -1,5 +1,7 @@
 import tape from 'tape-catch'
 const pull = require('pull-stream')
+// TODO: investigate pull-pair implicit dependency...
+// eslint-disable-next-line implicit-dependencies/no-implicit
 const DuplexPair = require('pull-pair/duplex')
 const { Libp2pSender } = require('../../../lib/net/protocol')
 

test/net/protocol/protocol.ts

@@ -1,11 +1,13 @@
 import tape from 'tape-catch'
 const td = require('testdouble')
 import { EventEmitter } from 'events'
-import { Sender } from '../../../lib/net/protocol/sender'
 import { Protocol } from '../../../lib/net/protocol/protocol'
 
 tape('[Protocol]', (t) => {
+  // TODO: remove lint ignores when disabled tests are uncommented
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   const BoundProtocol = td.replace('../../../lib/net/protocol/boundprotocol')
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   const Sender = td.replace('../../../lib/net/protocol/sender')
   const testMessage = {
     name: 'TestMessage',

test/rpc/helpers.ts

@@ -77,7 +77,7 @@ export function baseRequest(t: tape.Test, server: any, req: any, expect: any, ex
     .send(req)
     .expect(expect)
     .expect(expectRes)
-    .end((err: any, res: any) => {
+    .end((err: any) => {
       closeRPC(server)
       t.end(err)
     })

test/util/parse.ts

@@ -1,5 +1,4 @@
 import tape from 'tape-catch'
-import * as path from 'path'
 import { parseBootnodes, parseTransports, parseParams } from '../../lib/util'
 
 tape('[Util/Parse]', (t) => {