Do not allow v to be zero

ryanio · ryanio · commit dff5ca79c895 · 2021-02-11T18:08:31.000-08:00
diff --git a/packages/tx/src/transaction.ts b/packages/tx/src/transaction.ts
@@ -405,7 +405,7 @@ export default class Transaction {
    * Validates tx's `v` value
    */
   private _validateTxV(v: BN | undefined): void {
-    if (v === undefined || v.toNumber() === 0) {
+    if (v === undefined) {
       return
     }
 

Original file line number	Diff line number	Diff line change
`@@ -405,7 +405,7 @@ export default class Transaction {`
`405`	`405`	* Validates tx's `v` value
`406`	`406`	`*/`
`407`	`407`	`private _validateTxV(v: BN \| undefined): void {`
`408`		`- if (v === undefined \|\| v.toNumber() === 0) {`
	`408`	`+ if (v === undefined) {`
`409`	`409`	`return`
`410`	`410`	`}`
`411`	`411`