Skip to content

Expand bundle visualizer to monorepo#3465

Open
holgerd77 wants to merge 5 commits intomasterfrom
expand-bundle-visualizer-to-monorepo
Open

Expand bundle visualizer to monorepo#3465
holgerd77 wants to merge 5 commits intomasterfrom
expand-bundle-visualizer-to-monorepo

Conversation

@holgerd77
Copy link
Member

I started this work this morning since I would want to expand the new bundle visualizer from @roninjin10 to all monorepo packages.

However when I add a new vite.config.ts file the tsconfig.json file turns red along and gives out the following error message:

grafik

We should find out what is happening here before we continue here, maybe someone already has some insight.

Maybe this vite config additions directly to the build command have side effects (eventually already for EVM), and we would want to make sure that this does not affect other processes.

@acolytec3
Copy link
Contributor

Line 6-7 already shows up in VScode for me (has been for a while). Not sure about the node types issue but the one about module resolution can be fixed by changing our dev build environment from CJS to ESM.

@roninjin10
Copy link
Contributor

For the second error that looks like an actual misconfiguration of tsconfig. I think for a library like Ethjs module and moduleResolution being set to NodeNext is the ideal configuration.

The first error message maybe it just wants you to npm install @types/node?

@acolytec3
Copy link
Contributor

This might be solved with our recent of config changes. Will take another look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants