EthJS monorepo-wide errors: EVM package #3880
Closed
+1,746
−900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 85aa5fa Author: Jochem Brouwer <[email protected]> Date: Mon Feb 24 05:57:39 2025 +0100 lint: add rule to disallow `new Error` throwing commit 1e97567 Merge: a8cd9e1 bd77a74 Author: Jochem Brouwer <[email protected]> Date: Mon Feb 24 05:44:30 2025 +0100 Merge branch 'master' into evm-error-handling commit a8cd9e1 Author: Jochem Brouwer <[email protected]> Date: Mon Feb 24 05:44:21 2025 +0100 util: introduce new temp error with unset error code commit aa3702b Author: Jochem Brouwer <[email protected]> Date: Mon Feb 10 16:04:41 2025 +0100 vm/client: fix build commit 16d1b38 Author: Jochem Brouwer <[email protected]> Date: Mon Feb 10 15:40:57 2025 +0100 evm/util: update to new, simpler error format commit ec01f1b Author: Jochem Brouwer <[email protected]> Date: Mon Feb 10 14:37:24 2025 +0100 util: update base error class commit 70b2df5 Merge: 293f4cc 1774df6 Author: Jochem Brouwer <[email protected]> Date: Mon Feb 10 14:22:35 2025 +0100 Merge branch 'master' into evm-error-handling commit 293f4cc Merge: b4458d7 99cfdd6 Author: Jochem Brouwer <[email protected]> Date: Tue Jan 14 03:04:15 2025 +0100 Merge branch 'master' into evm-error-handling commit b4458d7 Merge: 71e77dc 100d77d Author: Jochem Brouwer <[email protected]> Date: Fri Dec 13 17:50:26 2024 +0100 Merge branch 'master' into evm-error-handling commit 71e77dc Author: Jochem Brouwer <[email protected]> Date: Tue Oct 1 13:57:38 2024 +0200 evm: fix err handling commit d00b7bf Author: Jochem Brouwer <[email protected]> Date: Tue Oct 1 13:46:08 2024 +0200 evm/util: error overhaul
client: add TODO
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jochem-brouwer
added
the
type: test all hardforks
Contributor
|
Is this something we still want to pursue @jochem-brouwer ? |
Member
Author
|
Not sure why this diff got so messed up, but the takeaway is this file: I think at some point it is worth experimenting with expanding the errors where it could provide meaningful info (for instance in this case: adding the revert bytes to to EVM error). I'll close this but will link to this PR / the specific file in #3712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #3714 (all commits there got squashed in a single commit here to avoid merge conflicts). This is a PR on top of #3879 to demonstrate integrating new error types.