Skip to content

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Apr 21, 2025

ethers currently is using an older version of @noble/hashes (v1.3.2) which is causing some duplication of versions of @noble/hashes in our monorepo.

ethers is only being used in vm for some ABI encoding/decoding utilities in 2 examples and one test so this replaces it with viem which has no dependencies and provides basically drop-in replacements for those tools.

Note, the robots wrote the actual translations of these functions and I reviewed/edited/tightened things up.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.39%. Comparing base (553334e) to head (d2ac623).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <ø> (ø)
blockchain 89.32% <ø> (ø)
common 97.50% <ø> (ø)
evm 73.08% <ø> (ø)
mpt 89.74% <ø> (ø)
statemanager 69.06% <ø> (ø)
static 99.77% <ø> (ø)
tx 89.83% <ø> (ø)
util 88.69% <ø> (ø)
vm 55.41% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gabrocheleau
gabrocheleau previously approved these changes Apr 21, 2025
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acolytec3 acolytec3 marked this pull request as draft April 21, 2025 18:38
@holgerd77
Copy link
Member

I generally guess we can take this in. I don't want to take in this very old package-lock.json though and am a bit afraid to re-generate myself after all the hazzle yesterday. So keeping this open for now (but everyone who is capable of a descent package-lock.json update feel free to update and merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants