Skip to content

refactor(types): improve unit name type safety and autocomplete #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(types): improve unit name type safety and autocomplete #4942

wants to merge 1 commit into from

Conversation

@skqksh
Copy link

@skqksh skqksh commented Feb 11, 2025 •
edited
Loading

  • Replaced unit name array with a typed constant object
  • Introduced UnitNameType for better type safety and autocompletion
  • Updated formatUnits and parseUnits functions to use UnitType instead of generic string
  • Update testcases

@kjeom kjeom mentioned this pull request Apr 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skqksh