fix(manifest): resolve node persistence after removal#4819
Merged
istae merged 5 commits intoethersphere:masterfrom Mar 6, 2025
Merged
fix(manifest): resolve node persistence after removal#4819istae merged 5 commits intoethersphere:masterfrom
istae merged 5 commits intoethersphere:masterfrom
Conversation
zelig
requested changes
Nov 3, 2024
Member
zelig
left a comment
zelig
left a comment
There was a problem hiding this comment.
very neat find. please simplify by just nil-ing the ref field
gacevicljubisa
changed the title
Member
Contributor
|
@asabya can you pls fix the commit msg, see https://github.com/ethersphere/bee/actions/runs/11669094347/job/33647232645?pr=4819#step:5:41 |
asabya
force-pushed
the
mantarayRemoveTest
branch
from
8787863 to
b31b0db
Compare
Contributor
Author
fixed |
gacevicljubisa
approved these changes
Jan 14, 2025
martinconic
approved these changes
Feb 10, 2025
acha-bill
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR fixes #4808. Where loading a manifest then removing forks from it would not persist in the next load.