fix(api): resolve header overwriting and delimiter issue in Access-Control-Expose-Headers#4960
Merged
fix(api): resolve header overwriting and delimiter issue in Access-Control-Expose-Headers#4960
Conversation
|
Would it be possible to add tests that check that headers are added instead of being replaced, to avoid a future regression? |
Member
Author
Yes, sure. |
janos
reviewed
Jan 29, 2025
janos
approved these changes
Jan 30, 2025
Member
janos
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing my comments.
istae
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…response header
Checklist
Description
;to,as per MDN documentation.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
[2.4.0] Access-Control-Expose-Headers is overridden, breaking browser Swarm apps #4959
Screenshots (if appropriate):