Merged
Conversation
acha-bill
approved these changes
Feb 27, 2025
gacevicljubisa
approved these changes
Feb 27, 2025
| reference swarm.Address, | ||
| historyRootHash swarm.Address, | ||
| ) (swarm.Address, error) { | ||
| ) (swarm.Address, swarm.Address, error) { |
Member
There was a problem hiding this comment.
Consider using named return values for clarity.
(encryptedRef, historyRef swarm.Address, err error)
martinconic
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
When uploading to any of the api endpoints the ACT relevant headers, i.e.: history address, are not added to the expose headers.
Adds the SwarmActHistoryAddressHeader to the AccessControlExposeHeaders, only if the Swarm-Act is set.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
fixes #5023
Screenshots (if appropriate):