Skip to content

Conversation

@nugaon
Copy link
Member

@nugaon nugaon commented Jul 4, 2025

related issue: #5137

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@nugaon nugaon changed the title fix: remove setting peer healthy true at undersaturated bins fix: remove setting peer healthy true in case of underpopulated bins Jul 4, 2025
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this change is logically and technically correct. But, I would wait for merging after the bee 2.6.0 release.

@gacevicljubisa
Copy link
Member

I think that this change is logically and technically correct. But, I would wait for merging after the bee 2.6.0 release.

Also, lets run this on light-testnet first.

@gacevicljubisa gacevicljubisa linked an issue Jul 7, 2025 that may be closed by this pull request
@gacevicljubisa
Copy link
Member

gacevicljubisa commented Jul 11, 2025

Should the log msg be different here:
https://github.com/ethersphere/bee/blob/15120e83cb0ef905d69b40f88f6a2a445e6fa3c7/pkg/salud/salud.go#L208C1-L209C1

Maybe: response duration above threshold?

@gacevicljubisa
Copy link
Member

Here are the metrics from bee-light-testnet. Also, when NetworkRadius=1 HealthRate was 0.

image

@gacevicljubisa gacevicljubisa self-requested a review July 21, 2025 11:21
@gacevicljubisa gacevicljubisa merged commit 1fc45e9 into master Jul 24, 2025
21 of 22 checks passed
@gacevicljubisa gacevicljubisa deleted the fix/min-peers-healthy branch July 24, 2025 11:02
@bcsorvasi bcsorvasi added this to the v2.7.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate health check in salud and fix possiible issues

6 participants