-
Notifications
You must be signed in to change notification settings - Fork 380
fix: cancel tx if missing from blockchain after some timeout #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Is there a way we can test this? |
Maybe we can test it mannualy with insufficient gas, invalid signature, low nonce, or insufficient funds. |
|
In general, I'm not sure about this mechanism. If there has been a transaction that has been signed, and broadcast to some RPC, while that RPC may have some failures of some sort, the As such, transactions should never be deemed "cancelled" unless in the circumstance that another transaction has been verified on chain that corresponds to the cancelled transaction's For example, if the transaction monitor sent to the RPC a transaction, and after some time, when checking the account's |
Checklist
Description
Cancel a tx if it's missing from the blockchain after a certain timeout—currently, 5 block times.
closes #5133