fix: register init metrics #5196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinconic
approved these changes
Aug 26, 2025
martinconic
approved these changes
Aug 27, 2025
janos
reviewed
Aug 27, 2025
pkg/node/metrics.go
Outdated
| func (m nodeMetrics) RegisterMetrics() { | ||
| prometheus.MustRegister(m.WarmupDuration) | ||
| prometheus.MustRegister(m.FullSyncDuration) | ||
| func Metrics(nodeMetrics nodeMetrics) []prometheus.Collector { |
Member
There was a problem hiding this comment.
This function does not need to be exported.
Member
Author
There was a problem hiding this comment.
I renamed to getMetrics because it was in conflict with the package name
akrem-chabchoub
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node init related metrics does not show up on
/metricsendpoint.Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):