refactor: init metrics #5198
Merged
refactor: init metrics #5198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
force-pushed
the
refactor/init-metric
branch
from
d06ce47 to
9bb1fe2
Compare
nugaon
requested review from
akrem-chabchoub,
janos,
martinconic and
sbackend123
Contributor
|
@nugaon Are the extended bucket ranges (10s to 10 minutes) intentionally designed to capture edge cases beyond the typical 0.5-7 minute warmup range? |
martinconic
approved these changes
Aug 27, 2025
nugaon
force-pushed
the
refactor/init-metric
branch
from
e29b9ae to
1c07890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default proposed buckets do not fit with current measurements.
Times measurements are collected from the new logs (0.5-7 mins warmup, ~2-3 hours pull sync) by which the buckets could be adjusted.
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):