fix: deduplicate concurrent ReserveSample calls with singleflight#5373
Open
gacevicljubisa wants to merge 1 commit intomasterfrom
Open
fix: deduplicate concurrent ReserveSample calls with singleflight#5373gacevicljubisa wants to merge 1 commit intomasterfrom
gacevicljubisa wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
@gacevicljubisa can you explain how are the concurrent calls possible? |
Member
Author
@acud I have updated the description with explanation. |
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos and
martinconic
janos
approved these changes
Feb 19, 2026
acud
approved these changes
Feb 20, 2026
akrem-chabchoub
approved these changes
Feb 24, 2026
Contributor
akrem-chabchoub
left a comment
akrem-chabchoub
left a comment
There was a problem hiding this comment.
Maybe some tests to cover these changes ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
fixes #5166
The problem: makeSample (storage incentives agent) and SampleWithProofs (
/rchashAPI endpoint) both can independently call ReserveSample, meaning concurrent calls with the same parameters would trigger duplicate expensive sampling operations.The fix: Introduces a singleflight.Group on the Agent struct to deduplicate concurrent calls. Both callers now go through a shared reserveSampleAndHash method keyed by anchor + depth. If multiple goroutines call it simultaneously with the same key, only one actual ReserveSample + sampleHash executes — the rest wait and share the result.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):