test(proxycall): improve non-blocking test with slow logger#20
Open
test(proxycall): improve non-blocking test with slow logger#20
Conversation
Replace TestClientResponseNotBlockedBySlowRequestBody with TestClientResponseNotBlockedBySlowLogging which properly verifies non-blocking behavior by: - Using a slow logger (200ms delay on request logging) - Verifying client receives response in <1ms - Asserting client response time < logging delay The previous test was flawed because slow request body also delays the upstream from receiving the request, so it couldn't prove the snooper wasn't adding latency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestClientResponseNotBlockedBySlowRequestBodywithTestClientResponseNotBlockedBySlowLoggingWhy
The previous test was flawed - a slow request body also delays the upstream from receiving the request, so it couldn't prove the snooper wasn't adding latency.
Test Results
Client receives response 240x faster than logging completes.