Skip to content

Conversation

@RogerPodacter
Copy link
Member

@RogerPodacter RogerPodacter commented Nov 24, 2025

  • Deleted the WordDomainsParser class and its references from the ProtocolParser, streamlining protocol handling.
  • Removed the name_registry contract and its related tests, eliminating legacy word-domain registration functionality.
  • Updated the L2Genesis contract to exclude the NameRegistry from proxied contract checks and registration.
  • Adjusted tests to reflect the removal of word-domains, ensuring consistency across the codebase.

Note

Removes all word-domains support (parser, contract, predeploy, registration) and updates parsers, genesis script, and tests accordingly.

  • Core parsing (Ruby):
    • Remove word-domains support: delete WordDomainsParser; drop mapping and plain-text fallback in ProtocolParser.
    • ProtocolParser.extract/for_calldata: unchanged for supported protocols; returns nil/default for non-protocol data.
  • Contracts:
    • Delete contracts/src/NameRegistry.sol and its tests; remove related imports/usages.
    • Remove Predeploys.NAME_REGISTRY constant.
    • Update L2Genesis.s.sol:
      • Exclude NameRegistry from proxied set and implementation setup.
      • Stop registering word-domains handler; only register ERC-20 fixed denomination and ERC-721 collection handlers.
  • Tests:
    • Remove word-domains specs; update protocol specs to exclude word-domains cases and assertions/comments related to it.
    • Keep ERC-20 and ERC-721 collection tests intact; adjust malformed JSON cases accordingly.

Written by Cursor Bugbot for commit 2a0b6ee. This will update automatically on new commits. Configure here.

- Deleted the `WordDomainsParser` class and its references from the `ProtocolParser`, streamlining protocol handling.
- Removed the `name_registry` contract and its related tests, eliminating legacy word-domain registration functionality.
- Updated the `L2Genesis` contract to exclude the `NameRegistry` from proxied contract checks and registration.
- Adjusted tests to reflect the removal of word-domains, ensuring consistency across the codebase.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleanly removes the legacy word-domains protocol support from the codebase, eliminating unused functionality and simplifying the protocol handling architecture. The changes span both Ruby application code and Solidity smart contracts, ensuring complete removal of the deprecated feature.

Key changes:

  • Removed the WordDomainsParser class and its associated test suite
  • Deleted the NameRegistry Solidity contract and its tests, which handled word-domain registrations as ERC-721 tokens
  • Updated the ProtocolParser to remove word-domains routing and the special case handling for plain text registrations

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/models/word_domains_parser_spec.rb Deleted comprehensive test suite for WordDomainsParser functionality
spec/models/protocol_parser_spec.rb Removed word-domains specific test cases from protocol parser tests
spec/models/erc721_ethscriptions_collection_parser_spec.rb Removed obsolete comment about 'data:,null' being a valid word-domains registration
contracts/test/NameRegistry.t.sol Deleted test suite covering registration, primary name setting, and transfer mirroring
contracts/src/libraries/Predeploys.sol Removed NAME_REGISTRY constant (address 0x3300...0007)
contracts/src/NameRegistry.sol Deleted entire NameRegistry contract implementation
contracts/script/L2Genesis.s.sol Removed NameRegistry from proxied contracts check, implementation setup, and protocol handler registration
app/models/word_domains_parser.rb Deleted parser class that validated and encoded word-domain operations
app/models/protocol_parser.rb Removed word-domains from protocol parser mapping and deleted try_plain_word_domains fallback method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RogerPodacter RogerPodacter merged commit 77f0636 into evm-backend-demo Nov 24, 2025
8 checks passed
@RogerPodacter RogerPodacter deleted the fix_collections branch November 24, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants