Fix missing dollar signs ($) on specific ps2 registers on the extra assembly files generated by make_full_disasm_for_code
#504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The remaining CI issue should fix itself when #501 gets merged. |
ethteck
approved these changes
Dec 24, 2025
Owner
ethteck
left a comment
ethteck
left a comment
There was a problem hiding this comment.
feel free to merge once change log is resolved
ethteck
pushed a commit
that referenced
this pull request
Dec 24, 2025
… assembly files generated by `make_full_disasm_for_code` (#504) * Emit `$` for special ps2 registers when using `make_full_disasm_for_code` * version bump * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't had time to test this PR, so I would be very thankful if ps2 people could to test it before merge.
Fixes #503