Conversation
Contributor
|
@wadesdev These changes look good to me. I would feel more comfortable with @RobertKeyser or @tvandort reviewing them first. |
RobertKeyser
approved these changes
Jun 4, 2025
Contributor
|
Looks good, but two things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When route53_config is set to null (the default), the validation tried to access properties of a null value, causing an error.
The changes fix the issue by adding a null check before trying to access properties of route53_config. Now when route53_config is null (which is the default), the validation will pass instead of throwing an error.