Skip to content

feat: update route_53 validation statements to permit default value#7

Merged
wadesdev merged 4 commits intomainfrom
OPS-946/update-route53-default-validation
Jun 4, 2025
Merged

feat: update route_53 validation statements to permit default value#7
wadesdev merged 4 commits intomainfrom
OPS-946/update-route53-default-validation

Conversation

@wadesdev
Copy link
Contributor

@wadesdev wadesdev commented Jun 3, 2025

When route53_config is set to null (the default), the validation tried to access properties of a null value, causing an error.

The changes fix the issue by adding a null check before trying to access properties of route53_config. Now when route53_config is null (which is the default), the validation will pass instead of throwing an error.

@github-actions github-actions bot added the terraform/fides-aws-ecs Code related to the fides-aws-ecs Terraform module label Jun 3, 2025
@jjdaurora
Copy link
Contributor

@wadesdev These changes look good to me. I would feel more comfortable with @RobertKeyser or @tvandort reviewing them first.

@wadesdev wadesdev requested a review from a team June 3, 2025 17:45
@RobertKeyser RobertKeyser self-requested a review June 4, 2025 20:34
@RobertKeyser
Copy link
Contributor

Looks good, but two things:

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 4, 2025
@wadesdev wadesdev merged commit 2e2ba6f into main Jun 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation terraform/fides-aws-ecs Code related to the fides-aws-ecs Terraform module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants