-
Notifications
You must be signed in to change notification settings - Fork 84
Re-invite Expired Users #6904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Re-invite Expired Users #6904
Conversation
24 hours seems a bit aggressive
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/two-factor-authentication |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6904 +/- ##
==========================================
- Coverage 87.47% 87.46% -0.01%
==========================================
Files 523 523
Lines 34090 34125 +35
Branches 3917 3922 +5
==========================================
+ Hits 29820 29848 +28
- Misses 3414 3418 +4
- Partials 856 859 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
81f2819 to
aed8847
Compare
ENG-1838
Description Of Changes
This PR allows email-invited users to be re-invited if they have not yet accepted the invite or their invite link has expired. Anyone with the user create scope can reinvite users. Upon the invitation being reissued, the old invite link is rendered invalid.
This addresses two issues: 1) where a user doesn't accept the invite in the TTL timeframe and 2) where the user has deleted or otherwise can't find the original invite link
Code Changes
api/v1/user/{user_id}/reinvite, scoped to user createSteps to Confirm
Reinviting a user before expiration
Trying an old access code (user had been reinvited before expiration period)

Reinviting a user with an expired invite
Trying an expired access code (before the user has been reinvited)

Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works