Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Jan 6, 2026

Ticket []

Description Of Changes

Fixing issue where non-array values were being passed to the api.

Code Changes

  • Updating tree action callback to handle arrays

Steps to Confirm

  1. Visit a datastore monitor screen
  2. Attempt to use the dropdown menu to action on a single item
  3. Confirm that the action sends an array value for the list of urns and completes successfully

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 6, 2026 8:27pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 6, 2026 8:27pm

@speaker-ender speaker-ender marked this pull request as ready for review January 6, 2026 20:28
@speaker-ender speaker-ender requested a review from a team as a code owner January 6, 2026 20:28
@speaker-ender speaker-ender requested review from gilluminate and removed request for a team January 6, 2026 20:28
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile Summary

This PR fixes a type mismatch where single-item tree actions were passing a single key value instead of an array of keys to action callbacks. The NodeAction callback signature expected Key[] (array), but the single-item dropdown menu handler in MonitorTreeDataTitle.tsx was passing node.key (single value) as the first argument.

Changes:

  • Updated NodeAction callback signature in types.d.ts from callback: (key: Key, nodes: N[]) => void to callback: (key: Key[], nodes: N[]) => void
  • Fixed the single-item action handler in MonitorTreeDataTitle.tsx to pass [node.key] (array) instead of node.key (single value)

This aligns the single-item actions with the multi-select actions (in MonitorTree.tsx lines 633-639 and 668-674), which already pass selectedNodeKeys (array) to the same callbacks. The underlying fieldActions (in useFieldActions.tsx) expect an array of URN strings (urns: string[]), so this fix ensures type consistency throughout the action chain.

Confidence Score: 5/5

  • This PR is safe to merge with no risk - it's a straightforward bug fix that corrects a type mismatch
  • The change is minimal, well-scoped, and directly addresses the stated issue. The fix aligns the single-item action behavior with the existing multi-select behavior, ensuring type consistency. All action handlers expect arrays of URNs, so this change is necessary and correct
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorTreeDataTitle.tsx Fixed single-item dropdown action to pass array of keys instead of single key value
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts Updated NodeAction callback signature to accept array of keys instead of single key

@speaker-ender speaker-ender added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit e2ab6fa Jan 6, 2026
54 of 56 checks passed
@speaker-ender speaker-ender deleted the fix/multi-select-tree-actions branch January 6, 2026 21:20
speaker-ender added a commit that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants