-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-2274 FE copy updates #7185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-2274 FE copy updates #7185
Conversation
Ignore modal Schema explorer empty state Classification failed message/toast
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR updates user-facing copy in three locations within the data discovery action center to improve clarity and grammatical correctness:
All changes are straightforward text updates with no logic modifications. Confidence Score: 5/5
Important Files Changed
|
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I've approved if we want to just get this change in quickly.
I did leave a comment about possibly updating the other text values to be less awkward sounding while we are making the change here but it's not a blocker.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/utils.ts
Outdated
Show resolved
Hide resolved
Allow users to filter by monitor type in the root action center. Acceptance criteria: Add a select filter to the root action center Allow users to filter by All monitors (default) Data store monitors Website monitors Infrastructure monitors (Future, don’t include this until we have the Okta monitor) Revert "ENG-2275 FE Allow monitor filtering in the root action center" This reverts commit 2d33c7f.
2d33c7f to
65c1ac7
Compare
Updated the error message function to use the generic "Action failed" message for all action types. It will show: "Action failed" for most actions "Action failed: View summary in the activity tab" for CLASSIFY and PROMOTE actions The FIELD_ACTION_COMPLETED import is still needed for the success message function, so it remains. No linting errors.
Ticket ENG-2274
Description Of Changes
Ignore modal
Schema explorer empty state
Classification failed message/toast
Code Changes
Steps to Confirm
When ignoring multiple resources we offer a confirmation modal that says “Are you sure you want to ignore [count] resources? After ignoring, these resources may reappear in future scans”. We should say instead “Are you sure you want to ignore [count] resources? After ignoring, these resources will not appear in future scans”.
In the schema explorer our empty state says “All resources have been approved” We should updated this to say “All resources have been either approved or ignored. Approved resources can be found in the manage datasets view. To see ignored resources, adjust your filters.”
When classification fails the message should say “Classification failed: View summary in the activity tab”
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works