Skip to content

Conversation

@jack-gale-ethyca
Copy link
Contributor

@jack-gale-ethyca jack-gale-ethyca commented Jan 6, 2026

Ticket ENG-2274

Description Of Changes

Ignore modal
Schema explorer empty state
Classification failed message/toast

Code Changes

  • copy changes

Steps to Confirm

  1. When ignoring multiple resources we offer a confirmation modal that says “Are you sure you want to ignore [count] resources? After ignoring, these resources may reappear in future scans”. We should say instead “Are you sure you want to ignore [count] resources? After ignoring, these resources will not appear in future scans”.

  2. In the schema explorer our empty state says “All resources have been approved” We should updated this to say “All resources have been either approved or ignored. Approved resources can be found in the manage datasets view. To see ignored resources, adjust your filters.”

  3. When classification fails the message should say “Classification failed: View summary in the activity tab”

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Ignore modal
Schema explorer empty state
Classification failed message/toast
@jack-gale-ethyca jack-gale-ethyca requested a review from a team as a code owner January 6, 2026 20:38
@jack-gale-ethyca jack-gale-ethyca requested review from speaker-ender and removed request for a team January 6, 2026 20:38
@vercel
Copy link

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 8, 2026 3:01pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 8, 2026 3:01pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile Summary

This PR updates user-facing copy in three locations within the data discovery action center to improve clarity and grammatical correctness:

  • Ignore confirmation modal: Changed message from "may reappear in future scans" to "will not appear in future scans" to accurately reflect the behavior of ignored resources
  • Empty state description: Restructured the message to clarify that both approved and ignored resources are no longer visible, with guidance on where to find each type
  • Classification error message: Fixed grammatical error by changing "Classified failed" to "Classification failed"

All changes are straightforward text updates with no logic modifications.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • All changes are simple text/copy updates with no logic modifications. The updates improve clarity and fix a grammatical error. No code behavior is altered, and the changes match the exact requirements specified in the PR description.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/FieldActions.const.tsx Updated ignore confirmation message to clarify resources will not reappear in future scans
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx Updated empty state description to explain both approved and ignored resources with clearer navigation guidance
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/utils.ts Changed classification error message from "Classified failed" to "Classification failed" for grammatical correctness

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile found no issues!

From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I've approved if we want to just get this change in quickly.
I did leave a comment about possibly updating the other text values to be less awkward sounding while we are making the change here but it's not a blocker.

Allow users to filter by monitor type in the root action center.

Acceptance criteria:

Add a select filter to the root action center

Allow users to filter by

All monitors (default)

Data store monitors

Website monitors

Infrastructure monitors (Future, don’t include this until we have the Okta monitor)

Revert "ENG-2275 FE Allow monitor filtering in the root action center"

This reverts commit 2d33c7f.
jack-gale-ethyca and others added 2 commits January 7, 2026 09:40
Updated the error message function to use the generic "Action failed" message for all action types. It will show:
"Action failed" for most actions
"Action failed: View summary in the activity tab" for CLASSIFY and PROMOTE actions
The FIELD_ACTION_COMPLETED import is still needed for the success message function, so it remains. No linting errors.
@jack-gale-ethyca jack-gale-ethyca added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 8f949d2 Jan 8, 2026
47 of 48 checks passed
@jack-gale-ethyca jack-gale-ethyca deleted the jg_test_branch branch January 8, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants