-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-2275 FE Allow monitor filtering in the root action center #7186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Allow users to filter by monitor type in the root action center. Acceptance criteria: Add a select filter to the root action center Allow users to filter by All monitors (default) Data store monitors Website monitors Infrastructure monitors (Future, don’t include this until we have the Okta monitor)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryAdded a monitor type filter dropdown to the root action center page allowing users to filter results by "All monitors", "Data store monitors", or "Website monitors". The implementation adds local state management for the selected filter, transforms the filter value into the appropriate Key changes:
Confidence Score: 5/5
Important Files Changed
|
|
@speaker-ender Keep a close eye on this one. If there's issues we can deny this and move on but if it works let's ship it! |
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor questions and nits but otherwise looks good!
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: 3nder <speaker_ender@protonmail.com>
"Website monitors" only appears when webMonitor flag is enabled "Data store monitors" only appears when heliosV2 flag is enabled "All monitors" only appears when at least one monitor type is enabled
Simplified the "all" case to return undefined, letting the API return all monitor types. The function is now simpler. No linting errors.
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions and questions about the intended functionality
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx
Outdated
Show resolved
Hide resolved
Action Center: conditionally show monitor type filter and remove redundant check Show filter only when 2+ monitor types are enabled (shouldShowFilter = filterOptions.length > 2) Remove redundant "all" check in getMonitorTypesFromFilter (default case handles it) Add Plus health endpoint for local development Remove scope requirement from Action Center nav item for local dev
|
@speaker-ender Ok made those changes. |
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change I forgot to point out.
Otherwise looks good!
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: 3nder <speaker_ender@protonmail.com>
Ticket ENG-2275
Description Of Changes
Allow users to filter by monitor type in the root action center.
Acceptance criteria:
Add a select filter to the root action center
Allow users to filter by
All monitors (default)
Data store monitors
Website monitors
Infrastructure monitors (Future, don’t include this until we have the Okta monitor)
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works