Skip to content

Conversation

@jack-gale-ethyca
Copy link
Contributor

@jack-gale-ethyca jack-gale-ethyca commented Jan 6, 2026

Ticket ENG-2275

Description Of Changes

Allow users to filter by monitor type in the root action center.

Acceptance criteria:

Add a select filter to the root action center

Allow users to filter by

All monitors (default)

Data store monitors

Website monitors

Infrastructure monitors (Future, don’t include this until we have the Okta monitor)

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Allow users to filter by monitor type in the root action center.

Acceptance criteria:

Add a select filter to the root action center

Allow users to filter by

All monitors (default)

Data store monitors

Website monitors

Infrastructure monitors (Future, don’t include this until we have the Okta monitor)
@jack-gale-ethyca jack-gale-ethyca requested a review from a team as a code owner January 6, 2026 21:32
@jack-gale-ethyca jack-gale-ethyca requested review from jpople and removed request for a team January 6, 2026 21:32
@vercel
Copy link
Contributor

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 13, 2026 2:13pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 13, 2026 2:13pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile Summary

Added a monitor type filter dropdown to the root action center page allowing users to filter results by "All monitors", "Data store monitors", or "Website monitors". The implementation adds local state management for the selected filter, transforms the filter value into the appropriate MONITOR_TYPES array for the API query, and properly resets pagination when the filter changes.

Key changes:

  • Added Select component import and new selectedFilter state
  • Created getMonitorTypesFromFilter function to map filter values to MONITOR_TYPES arrays
  • Updated useEffect dependency array to include selectedFilter for pagination reset
  • Added filter dropdown UI with proper test ID and styling

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The implementation is straightforward and follows existing patterns in the codebase. The changes are well-contained to a single component, properly handle state management, correctly reset pagination when filters change, and maintain backward compatibility with feature flags. The code is clean, readable, and aligns with the PR requirements.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx Added monitor type filter dropdown with proper state management and pagination reset

@jack-gale-ethyca
Copy link
Contributor Author

jack-gale-ethyca commented Jan 6, 2026

@speaker-ender Keep a close eye on this one. If there's issues we can deny this and move on but if it works let's ship it!

@jack-gale-ethyca jack-gale-ethyca requested review from speaker-ender and removed request for jpople January 6, 2026 21:37
Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions and nits but otherwise looks good!

Co-authored-by: 3nder <speaker_ender@protonmail.com>
"Website monitors" only appears when webMonitor flag is enabled
"Data store monitors" only appears when heliosV2 flag is enabled
"All monitors" only appears when at least one monitor type is enabled
Simplified the "all" case to return undefined, letting the API return all monitor types. The function is now simpler. No linting errors.
Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions and questions about the intended functionality

Action Center: conditionally show monitor type filter and remove redundant check
Show filter only when 2+ monitor types are enabled (shouldShowFilter = filterOptions.length > 2)
Remove redundant "all" check in getMonitorTypesFromFilter (default case handles it)
Add Plus health endpoint for local development
Remove scope requirement from Action Center nav item for local dev
@jack-gale-ethyca
Copy link
Contributor Author

@speaker-ender Ok made those changes.

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change I forgot to point out.
Otherwise looks good!

Co-authored-by: 3nder <speaker_ender@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants