-
Notifications
You must be signed in to change notification settings - Fork 84
Migrate consent reporting table to Ant Design #7187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate consent reporting table to Ant Design #7187
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
c145a31 to
dc4816e
Compare
Greptile SummaryThis PR successfully migrates the consent reporting table from FidesTableV2 (TanStack Table with Chakra UI) to Ant Design Table component. Key Changes:
Implementation Quality:
Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, 5 comments
8d1e333 to
155ba18
Compare
jack-gale-ethyca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new table is looking good! Code changes look good. Just a few small comments for improvement but I'll leave the approve too:
- The "User device ID" and "Preference ID" have ellipsis but no tooltip to see the full text. The original table didn't have those either, but I think it's important to be able to see the full id.
- The relative timestamp column doesn't show ellipsis properly and wraps to a 2nd line:
@lucanovera Both the old and new tables use a |
I do see the built-in browser tooltip. I meant we could add the Ant Tooltip that will let you copy the text too. |
6f86d82 to
89210c9
Compare
|
@lucanovera fixed! I've added an EllipsisCell component and applied that to other tables that could benefit as well. |
Ticket ENG-702
Description Of Changes
Migrated the consent reporting table from FidesTableV2 (TanStack Table with Chakra UI) to Ant Design Table component.
Replaced custom table components with Ant Design equivalents and created a reusable
EllipsisCellcomponent for text truncation with tooltips (for tables to using fixed width columns)Code Changes
EllipsisCellcomponentSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works