-
Notifications
You must be signed in to change notification settings - Fork 84
Add infrastructure monitor type to action center gated behind oktaMonitor feature flag #7191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR adds support for infrastructure monitor type (used for Okta monitors) in the action center, gated behind the Key changes:
Issue found:
Confidence Score: 2/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
clients/admin-ui/src/pages/data-discovery/action-center/index.tsx, line 74-76 (link)logic: this check doesn't include
oktaMonitorEnabled, so if only theoktaMonitorflag is enabled, users will see the disabled page even though infrastructure monitors should be available
3 files reviewed, 1 comment
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The infrastructure monitor results now appear when the flag is on, code changes are simple and correct.
This is approved for me, but we shouldn't merge this until the BE changes are merged. If we merge this without BE support, the action center endpoint breaks because of the lack of support for the 'infrastructure' value.
Let me know when that is approved and I'll approve this.
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BE is merged already. Approved!
…results-for-infra
Ticket ENG-2270
Description Of Changes
Add support for the infrastructure monitor type in the action center, gated behind the
oktaMonitorfeature flag. Infrastructure monitor results (used for Okta monitors) will now appear in the action center when the feature flag is enabled, consistent with how website and datastore monitor types are handled.Code Changes
oktaMonitorfeature flag from flags objectMONITOR_TYPES.INFRASTRUCTUREto monitor types array conditionally whenoktaMonitorEnabledis trueSteps to Confirm
oktaMonitorfeature flag is enabledoktaMonitorfeature flag is disabledPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works